[Webkit-unassigned] [Bug 125926] [GStreamer] WebKit gets stalled when trying to play a stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125926





--- Comment #19 from Andres Gomez Garcia <agomez at igalia.com>  2014-02-27 14:29:38 PST ---
(From update of attachment 225346)
View in context: https://bugs.webkit.org/attachment.cgi?id=225346&action=review

>>> LayoutTests/http/tests/media/resources/serve-video.php:79
>>> +                $id3Url = "http://sourceforge.net/projects/getid3/files/latest/download?source=files";
>> 
>> The script to update the database should not be the same script that's run as part of tests, it's just too confusing. I can think if a few options, but Eric is the better one to advise on the course of action:
>> 
>> - Check in the whole getid3 (assuming its license is compatible), and have a script to update the database, which one will need to run when changing the assets.
>> - Have a separate script for this purpose, that will download getid3 like here.
>> - Check in the whole getid3 (assuming its license is compatible), and just parse the files every time, not checking in the database.
> 
> I agree with Alexey, we will not need to recreate the database very often so it doesn't make sense to have the database creation code inside of the test. I think a separate script that downloads getid3 as necessary is the way to go.

I agree it would be better to move to a different script.

Due to licensing, best is to download under demand and recreate the db then.

Still, I'm unsure how to provide this script. Do you think it is OK just by providing a single PHP file with comments for calling ./Tools/Scripts/run-webkit-httpd and the URL to call for regenerating the db or are you thinking in something more complex like another python script in ./Tools/Scripts that would be doing also this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.