[Webkit-unassigned] [Bug 125926] [GStreamer] WebKit gets stalled when trying to play a stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125926





--- Comment #18 from Eric Carlson <eric.carlson at apple.com>  2014-02-27 14:05:53 PST ---
(In reply to comment #17)
> (From update of attachment 225346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225346&action=review
> 
> >> LayoutTests/http/tests/media/resources/media-stream-chunked-icy.php:10
> >> +    $_GET["icy-data"] = "yes";
> > 
> > I don't understand why this script is needed. All it does is add two _GET arguments, so why don't we just pass all the arguments in media-play-stream-chunked-icy.html?
> 
> The rest of the existing tests using the previously existing "serve-video.php" are using this kind of proxy php scripts.
> 
> I can just pass the arguments and call "serve-video.php" directly but I was following the examples. What do you think?
> 
I think calling serve-video.php directly is a good idea since you have folded the icy server functionality into it.

> >> LayoutTests/http/tests/media/resources/serve-video.php:184
> >> +    header("HTTP/1.1 " . $settings["httpStatus"]);
> > 
> > This looks suspicious. Is sending the HTTP/1.1 line something one actually needs to do?
> 
> This line is part of the existing script. My update was just the variable used. I didn't want to change the functionality that is already working for the existing tests.

I believe it is necessary because the script generates the entire header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.