[Webkit-unassigned] [Bug 104147] Math.{max, min}() must not return after first NaN value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104147


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #24 from Darin Adler <darin at apple.com>  2014-02-27 12:26:36 PST ---
I still think this caused a regression.

It seems to me that we will keep calling toNumber on subsequent arguments even if an exception occurred when calling toNumber on the first argument. I am not sure why the regression test did not cover this case, but I see no way the code could be doing the right thing. We need to exit the loop when an exception occurs, and we used to do that as a side effect because we would exit the loop any time a NAN was returned.

I see the test case that is supposed to test this, and I don’t understand why it doesn’t fail. Someone should look in the debugger and find out!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.