[Webkit-unassigned] [Bug 125926] [GStreamer] WebKit gets stalled when trying to play a stream

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 27 11:22:26 PST 2014


--- Comment #16 from Eric Carlson <eric.carlson at apple.com>  2014-02-27 11:19:31 PST ---
(From update of attachment 225346)
View in context: https://bugs.webkit.org/attachment.cgi?id=225346&action=review

> LayoutTests/http/tests/media/media-play-stream-chunked-icy.html:10
> +            var type = mimeTypeForExtension(media.split('.').pop());
> +            var audio;

Nit: these variables are only used inside of start() so they can be declared there.

>> LayoutTests/http/tests/media/resources/serve-video.php:79
>> +                $id3Url = "http://sourceforge.net/projects/getid3/files/latest/download?source=files";
> The script to update the database should not be the same script that's run as part of tests, it's just too confusing. I can think if a few options, but Eric is the better one to advise on the course of action:
> - Check in the whole getid3 (assuming its license is compatible), and have a script to update the database, which one will need to run when changing the assets.
> - Have a separate script for this purpose, that will download getid3 like here.
> - Check in the whole getid3 (assuming its license is compatible), and just parse the files every time, not checking in the database.

I agree with Alexey, we will not need to recreate the database very often so it doesn't make sense to have the database creation code inside of the test. I think a separate script that downloads getid3 as necessary is the way to go.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list