[Webkit-unassigned] [Bug 115650] [GTK][WK2] Blocks when fetching plugins information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115650


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225356|review?                     |review+
               Flag|                            |




--- Comment #10 from Gustavo Noronha (kov) <gns at gnome.org>  2014-02-27 07:49:58 PST ---
(From update of attachment 225356)
View in context: https://bugs.webkit.org/attachment.cgi?id=225356&action=review

LGTM!

> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:87
> +    g_file_set_contents(m_cachePath.get(), data.get(), dataLength, nullptr);

I guess we don't have to be concerned about multiple webkit clients trying to write to the file at the same time since this is atomic, right?

> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:135
> +    // Save the cache file in an idle to make sure it happens in the main thread and
> +    // it's done only once when this is called multiple times in a very short time.
> +    if (m_saveToFileIdleId)
> +        return;

I assume this is called from a single thread, so we don't need to perform any locking of the m_saveToFileIdleId member.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.