[Webkit-unassigned] [Bug 125926] [GStreamer] WebKit gets stalled when trying to play a stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125926





--- Comment #14 from Andres Gomez Garcia <agomez at igalia.com>  2014-02-27 01:01:39 PST ---
First, sorry for the refactoring but I thought that it actually made more sense to add this functionality to the existent "serve-video.php" file.

(In reply to comment #9)
> (From update of attachment 225065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225065&action=review
> 
> > LayoutTests/http/tests/media/resources/stream/media.db:1
...
> How was this database generated, with getid3? Please a script to your patch so someone later can regenerate it if necessary.

I've renamed the db to metadata.db and moved to the directory scanned at each moment, as it makes more sense.

Now, the db is regenerated by the own code of the PHP script by downloading getid3. Its regeneration can also be forced if passed the "create-database=yes" in the GET method.

> > LayoutTests/http/tests/media/resources/stream/stream-media.php:13
> > +    /* $fileName = basename($filePath); */
> 
> Nit: if this was left here for a purpose, please say so in a comment. if not, please remove.

This disappeared already in the first correcting patch.

> > LayoutTests/http/tests/media/resources/stream/stream-media.php:21
> > +    $ranges = array_key_exists("ranges", $_GET) ? $_GET["ranges"] : "yes";
> 
> Is there any reason to not use byte ranges?

Now this is actually part of the existent previous funcionality to be able to keep testing servers not supporting range requests.

> > LayoutTests/http/tests/media/resources/stream/stream-media.php:22
> > +    $setMetadata = array_key_exists("send-metaint", $_GET) ? $_GET["send-metaint"] : "no";
> 
> Is there any reason to not send metadata?

This is actually a flag to send a specific Icecast/Shoutcast header informing at which frequency it will be sent specific metadata of the file being played currently.

This is only supported when streaming MP3 files.

Maybe creating a specific test case for this would make sense but I'm unsure right now of whether this is something we want and also how to proceed with a test when MP3 files support is probably not guarantee on every port.

I've removed this by now, as it is not needed for this specific test.

> > LayoutTests/http/tests/media/resources/stream/stream-media.php:106
> > +    if ($httpStatus == "404 Not Fond")
> > +        exit;
> 
> It would be good to fail with something more informative than a 404. Is it possible to log something to stderr so it shows up in the test results?

Now we have logging in Apache log and we return a more verbose HTML.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.