[Webkit-unassigned] [Bug 129263] WebKitFindOptions shouldn't expose WEBKIT_FIND_OPTIONS_SHOW_{OVERLAY, FIND_INDICATOR, HIGHLIGHT}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129263


Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225079|review?                     |review-
               Flag|                            |




--- Comment #4 from Sergio Villar Senin <svillar at igalia.com>  2014-02-25 09:11:18 PST ---
(From update of attachment 225079)
View in context: https://bugs.webkit.org/attachment.cgi?id=225079&action=review

Almost there. I'd suggest some changes tough.

> Source/WebKit2/ChangeLog:7
> +

You still need a short description of the problem/fix here even if you add specific comments per file.

> Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:99
> +

I don't see the point of having two functions. Let's just have the one receiving a uint32_t and let it do all the conversion, we don't need an extra cast and a function call (even if it's inline)

> Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:112
>  }

Same here, I think we only use the second one, so let's keep that and move the implementation of the conversion there.

> Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:433
> +    webKitFindControllerSetSearchData(findController, searchText, toFindOptions(static_cast<WebKitFindOptions>(findOptions)), maxMatchCount);

Just call the uint32_t version, you don't need the cast.

> Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:490
> +    webKitFindControllerSetSearchData(findController, searchText, toFindOptions(static_cast<WebKitFindOptions>(findOptions)), maxMatchCount);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.