[Webkit-unassigned] [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129098





--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org>  2014-02-25 03:54:28 PST ---
(In reply to comment #11)
> Our solution made a bad impression by admitting that we end up implicitly inserting a node under a non-editable element, yet we found this approach to be the lesser evil.

It didn't make a bad impression. I noticed this without reading the change log. The only reason I commented on the change log was because you explicitly mentioned it. I would have r-ed it regardless.

We shouldn't be modifying a node outside of a root content editable node. In fact, as it stands, we support -webkit-user-modify CSS property to control the editability so we must constantly query whether a given node is editable or not since a mere act of inserting a new node could affect the editability in the presence of that CSS property.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.