[Webkit-unassigned] [Bug 129223] Build breaking due to linking error on clang with libc++

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 24 12:39:56 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129223





--- Comment #8 from Zan Dobersek <zandobersek at gmail.com>  2014-02-24 12:37:04 PST ---
The imported gtest code is quite old, 1.5.0 was released in April 2010.

Still, I can build gtest with Clang 3.4 and libc++ 1.0 (r199600) after applying a small patch:

diff --git a/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h b/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
index e8c6ae0..3b09af1 100644
--- a/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
+++ b/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
@@ -197,7 +197,7 @@
 #define GTEST_PROJECT_URL_ "http://code.google.com/p/googletest/"

 // Determines the version of gcc that is used to compile this.
-#ifdef __GNUC__
+#if defined(__GNUC__) && !defined(__clang__)
 // 40302 means version 4.3.2.
 #define GTEST_GCC_VER_ \
     (__GNUC__*10000 + __GNUC_MINOR__*100 + __GNUC_PATCHLEVEL__)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list