[Webkit-unassigned] [Bug 128958] Add support for the isolation property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128958





--- Comment #8 from Dirk Schulze <krit at webkit.org>  2014-02-24 07:22:05 PST ---
(From update of attachment 225055)
View in context: https://bugs.webkit.org/attachment.cgi?id=225055&action=review

The patch looks good to me. Just two snippets. I give the other reviewers some time to review the patch as well before giving my r+. Maybe Simon has more comments.

> Source/WebCore/rendering/style/RenderStyle.h:974
> +    void setBlendMode(BlendMode v) { SET_VAR(rareNonInheritedData, m_effectiveBlendMode, v); }
>      bool hasBlendMode() const { return static_cast<BlendMode>(rareNonInheritedData->m_effectiveBlendMode) != BlendModeNormal; }
> +
> +    Isolation isolation() const { return static_cast<Isolation>(rareNonInheritedData->m_isolation); }
> +    void setIsolation(Isolation v) { SET_VAR(rareNonInheritedData, m_isolation, v); }

should still have longer names like blendMode and isolation instead of v. Regardless of the use elsewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.