[Webkit-unassigned] [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128422





--- Comment #24 from Diego Pino <dpino at igalia.com>  2014-02-24 04:26:42 PST ---
(In reply to comment #21)
> (From update of attachment 224848 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224848&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/js.py:74
> > +            #  Remove "double quoted" strings.
> 
> Double space in comment.
> 
> > Tools/Scripts/webkitpy/style/checkers/js.py:80
> > +                    line = line[:single_line_comment_pos]
> 
> Double indent.
> 

Fixed in r164582.

> > Tools/Scripts/webkitpy/style/checkers/js.py:91
> > +                self._handle_style_error(line_number, "js/syntax", 5, "Line contains single-quote character.")
> 
> It might be nice to dump the line at the same time.

Agree, but I think that in case of solving that it makes to do it in for all type of errors, that means to change how handle_style_error works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.