[Webkit-unassigned] [Bug 127800] WebKitGTK+ should stop using COMPILE_ASSERT_MATCHING_ENUM macros

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127800





--- Comment #20 from Sergio Villar Senin <svillar at igalia.com>  2014-02-24 03:01:48 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > (In reply to comment #17)
> > 
> > > > Source/WebKit2/UIProcess/API/gtk/WebKitFindController.h:69
> > > > +  /*< private >*/
> > > > +  WEBKIT_FIND_OPTIONS_SHOW_OVERLAY =                       1 << 5,
> > > > +  WEBKIT_FIND_OPTIONS_SHOW_FIND_INDICATOR =                1 << 6,
> > > > +  WEBKIT_FIND_OPTIONS_SHOW_HIGHLIGHT =                     1 << 7,
> > > 
> > > I don't think we should expose these here, even when using the private  comment.
> > 
> > Then, what should we do in toWebKitFindOptions() when WebKitFindOptions has FindOptionsShowOverlay, FindOptionsShowFindIndicator or FindOptionsShowHighlight enabled? Assert?
> 
> You should not call the convert functions with those values, since they are used internally.

I agree with Carlos FWIW

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.