[Webkit-unassigned] [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 21 10:43:50 PST 2014


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #224848|commit-queue?               |commit-queue+
               Flag|                            |

--- Comment #21 from Joseph Pecoraro <joepeck at webkit.org>  2014-02-21 10:41:00 PST ---
(From update of attachment 224848)
View in context: https://bugs.webkit.org/attachment.cgi?id=224848&action=review

> Tools/Scripts/webkitpy/style/checkers/js.py:74
> +            #  Remove "double quoted" strings.

Double space in comment.

> Tools/Scripts/webkitpy/style/checkers/js.py:80
> +                    line = line[:single_line_comment_pos]

Double indent.

> Tools/Scripts/webkitpy/style/checkers/js.py:91
> +                self._handle_style_error(line_number, "js/syntax", 5, "Line contains single-quote character.")

It might be nice to dump the line at the same time.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list