[Webkit-unassigned] [Bug 129145] [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129145


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224845|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-02-21 02:27:44 PST ---
(From update of attachment 224845)
View in context: https://bugs.webkit.org/attachment.cgi?id=224845&action=review

Thanks for the patch. I think we should add a test case for this.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:897
> +        if ($paramIDLType eq "CompareHow") {
> +           return "";
> +        }

This is not correct, this method should not be called for non pointer types. We are currently checking whether the param type is primitve or not, but we should actually check that is a pointer type.

my $paramTypeIsPrimitive = $codeGenerator->IsPrimitiveType($paramIDLType);
my $paramIsGDOMType = IsGDOMClassType($paramIDLType);
if (!$paramTypeIsPrimitive) {
    $gReturnMacro = GetGReturnMacro($paramName, $paramIDLType, $returnType, $functionName);
    push(@cBody, $gReturnMacro);
}

We should use 

my $paramTypeIsPointer = !$codeGenerator->IsNonPointerType($paramIDLType);

You can also remove the paramIsGDOMType that is unused :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.