[Webkit-unassigned] [Bug 129051] GetMyArgumentsByLength in FTL doesn't work with inline code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 13:56:36 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129051


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224654|review+                     |review-
               Flag|                            |




--- Comment #6 from Filip Pizlo <fpizlo at apple.com>  2014-02-20 13:53:46 PST ---
(From update of attachment 224654)
Actually, this test is broken.  There's no way it even hits the FTL since it relies on global code.  Did you test the test?  It's very important that when you add a test, you check that it indeed reproduces the bug you're trying to fix.  I don't buy that this test gives us coverage over the old version of this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list