[Webkit-unassigned] [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129098


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224747|review?                     |review-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2014-02-20 13:45:33 PST ---
(From update of attachment 224747)
View in context: https://bugs.webkit.org/attachment.cgi?id=224747&action=review

> Source/WebCore/ChangeLog:12
> +        Editing commands executed during
> +        ReplaceSelectionCommand::moveNodeOutOfAncestor() (utilized by
> +        makeInsertedContentRoundTrippableWithHTMLTreeBuilder and responsible for
> +        moving prohibited children out of their ancestors) are not applied
> +        properly when attempting to modify a non-editable element.

We should never be modifying non-editable element.
That's what we need to fix.
We shouldn't be working-around our bugs like this by ignoring contenteditable value.
r-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.