[Webkit-unassigned] [Bug 129048] Setting playback rate on video with media controller is not ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129048





--- Comment #9 from Eric Carlson <eric.carlson at apple.com>  2014-02-20 12:43:01 PST ---
(From update of attachment 224659)
View in context: https://bugs.webkit.org/attachment.cgi?id=224659&action=review

> LayoutTests/media/video-controller-child-rate.html:49
> +            function timeupdate()
> +            {
> +                if (videoLastTime == -1) {
> +                    videoLastTime = video.currentTime;
> +                    lastRealTime = new Date();
> +                    return;
> +                }
> +
> +                var videoTimeDelta = video.currentTime - videoLastTime;
> +                var realTimeDelta = new Date() - lastRealTime;
> +                if (videoTimeDelta > realTimeDelta / 500)
> +                    failTest("Playback rate was aplied directly to video with media controller.");
> +
> +                endTest();
> +            }

This is not exactly what I suggested in my earlier review. First, I think you should look at several 'timeupdate' events because the latency before the first is extremely variable. Second, I think you should directly compare the wall clock and media clock deltas and fail if they are more than a small percentage different, e.g. something like: 

    testExpected(Math.abs(videoTimeDelta - realTimeDelta) / 100, 2, ">")

I typed this in the browser so it may not be quite right, but you should get the idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.