[Webkit-unassigned] [Bug 129048] Setting playback rate on video with media controller is not ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129048





--- Comment #8 from Jer Noble <jer.noble at apple.com>  2014-02-20 12:19:45 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 224650 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=224650&action=review
> > 
> > > Source/WebCore/html/HTMLMediaElement.cpp:2571
> > >  double HTMLMediaElement::playbackRate() const
> > >  {
> > > -    return m_playbackRate;
> > > +    return m_mediaController ? m_mediaController->playbackRate() : m_playbackRate;
> > >  }
> > 
> > I would prefer a new method called "effectivePlaybackRate()".  Changing playbackRate() to return the media controller rate violates the spec: "The [playbackRate] attribute is mutable: on getting it must return the last value it was set to, or 1.0 if it hasn't yet been set; on setting the attribute must be set to the new value, and the playback will change speed (if the element is potentially playing and there is no current media controller)."
> 
> Yes, but earlier you have:
> The playbackRate attribute gives the effective playback rate (assuming there is no current media controller overriding it), which is the speed at which the media resource plays,
> 
> and then:
> The effective playback rate is not necessarily the element's playbackRate. When a media element has a current media controller, its effective playback rate is the MediaController's media controller playback rate.

Yes exactly.  The playbackRate _is_ the effective playback rate, _unless_ there is a current media controller.

I think you might be confusing the causality of "effective playback rate".  playbackRate is setting what the "effective playback rate" should be, not returning what the media engine reports the "effective playback rate" to be.

As such, your most recent patch is still incorrect.  We should not be returning the media controller's playbackRate from HTMLMediaElement::playbackRate().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.