[Webkit-unassigned] [Bug 124999] [Texmap] TextureMapperLayer unnecessary object copying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 02:44:03 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=124999





--- Comment #6 from Przemyslaw Szymanski <p.szymanski3 at samsung.com>  2014-02-20 02:41:13 PST ---
(In reply to comment #4)
> (From update of attachment 218041 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218041&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:348
> >      for (size_t i = 0; i < rects.size(); ++i) {
> 
> Please make this a C++11 loop.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:369
> > +        const IntRect& rect = rects[i];
> 
> Ditto.

Thank you for review. Patch is updated. I hope you thought about range-for not std::foreach

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list