[Webkit-unassigned] [Bug 129045] [Win][LLINT] Incorrect stack alignment.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129045





--- Comment #14 from Geoffrey Garen <ggaren at apple.com>  2014-02-19 12:18:49 PST ---
> > Windows is not the only platform on which the incoming stack is unaligned. For example, the same is true on ARM32. Can we share some of this code? It seems like aligning the stack is a generic action in the LLInt. We need to avoid adding too much Windows-specific cruft to the LLInt.
> 
> Is this something that could be done with a macro?

Possibly.

What we want, ideally, is a cross-platform idiom like this:

if (!incomingStackIsAligned())
    alignStack();

'incomingStackIsAligned()' would return false on Windows and ARM32, and true on some other platforms. alignStack() might have a shared implementation on all platforms based on our abstract fp and sp registers -- or it might need a specific implementation on some platforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.