[Webkit-unassigned] [Bug 129048] Setting playback rate on video with media controller is not ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129048


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224650|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Jer Noble <jer.noble at apple.com>  2014-02-19 10:45:57 PST ---
(From update of attachment 224650)
View in context: https://bugs.webkit.org/attachment.cgi?id=224650&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2571
>  double HTMLMediaElement::playbackRate() const
>  {
> -    return m_playbackRate;
> +    return m_mediaController ? m_mediaController->playbackRate() : m_playbackRate;
>  }

I would prefer a new method called "effectivePlaybackRate()".  Changing playbackRate() to return the media controller rate violates the spec: "The [playbackRate] attribute is mutable: on getting it must return the last value it was set to, or 1.0 if it hasn't yet been set; on setting the attribute must be set to the new value, and the playback will change speed (if the element is potentially playing and there is no current media controller)."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.