[Webkit-unassigned] [Bug 129040] [glib] Update the battery provider to UPower 1.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129040


WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org




--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2014-02-19 05:39:12 PST ---
Attachment 224627 did not pass style-queue:


ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:36:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:36:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:37:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:38:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:38:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:39:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:39:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:39:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:40:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:86:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:87:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:88:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:90:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:100:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/glib/BatteryProviderUPower.cpp:102:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 26 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.