[Webkit-unassigned] [Bug 128904] [GTK] ASSERTION FAILED: hasClass()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128904


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224493|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Anders Carlsson <andersca at apple.com>  2014-02-18 07:50:43 PST ---
(From update of attachment 224493)
View in context: https://bugs.webkit.org/attachment.cgi?id=224493&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:122
> +    if (!toElement(&node)->hasClass())
> +        return false;
> +
> +    return toElement(&node)->classNames().contains(className);

As I suggested, please put the element in a local variable here to avoid calling toElement twice (since toElement is a virtual call):

const Element& element = toElement(node);
(or *toElement(*node) if there's no version that takes references).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.