[Webkit-unassigned] [Bug 128723] [css3-text] Support -webkit-text-decoration-skip: objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128723





--- Comment #14 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2014-02-17 20:47:00 PST ---
(In reply to comment #12)
> (From update of attachment 224167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224167&action=review
> 
> > LayoutTests/fast/css/text-decoration-skip-atomic-inline.html:3
> > +.underline { text-decoration: underline; color: red; }
> 
> Don't you want to explicitly say text-decoration-skip: objects in case we change the default to 'auto'?

Changed to text-decoration-skip: objects only test because the spec doesn't say that text-decoration-skip: ink should skip atomic inlines.
Since there is no definition of 'auto', I assumed that 'auto' is equivalent to 'ink'.

> > LayoutTests/fast/css/text-decoration-skip-atomic-inline.html:7
> > +<div class="underline"><img class="margin-border-padding" src="resources/greenbox.png" /><table style="display: inline-table; "><td class="margin-border-padding">inline-table</table><div class="margin-border-padding" style="display: inline-block; ">inline-block</div><input class="margin-border-padding" type="button" value="button" /><video class="margin-border-padding" src="dummy.mp4"></video><canvas class="margin-border-padding" width="10" height="10"></canvas><iframe class="margin-border-padding"></iframe></div>
> 
> Do these have to all be squished onto one line?

Split into 3 lines.

> I think it would be better for the test to show at least some underlined text so we can see if any underlining was done.

Made description underlined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.