[Webkit-unassigned] [Bug 128934] Make TreeScope::rootNode return a reference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128934


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224428|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2014-02-17 15:02:49 PST ---
(From update of attachment 224428)
View in context: https://bugs.webkit.org/attachment.cgi?id=224428&action=review

r=me assuming it builds.

> Source/WebCore/dom/Document.cpp:716
> +    ContainerNode& rootNode = scope->rootNode();
> +    for (auto& element : descendantsOfType<Element>(rootNode)) {

I don't think you need the 'rootNode' local.

> Source/WebCore/dom/ShadowRoot.h:98
> +inline bool isShadowRoot(const Node& node) { return node.isElementNode() && toElement(node).isShadowRoot(); }

Why do you need the isElementNode() check? Node has isShadowRoot().

> Source/WebCore/dom/ShadowRoot.h:100
> +NODE_TYPE_CASTS(ShadowRoot);

You don't need the semicolon here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.