[Webkit-unassigned] [Bug 128625] Add fast mapping from StringImpl to JSString

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128625





--- Comment #5 from Andreas Kling <akling at apple.com>  2014-02-17 14:43:16 PST ---
(From update of attachment 224417)
View in context: https://bugs.webkit.org/attachment.cgi?id=224417&action=review

I'm not JSC ninja enough to do final review, so here's some minor comments. (This looks really awesome to me btw.)

> Source/JavaScriptCore/runtime/JSString.cpp:305
> +    impl->setWeakJSString(0);

0 -> nullptr

> Source/JavaScriptCore/runtime/JSString.h:66
> +        class WeakOwner : public WeakHandleOwner {

final

> Source/JavaScriptCore/runtime/JSString.h:68
> +            virtual void finalize(Handle<Unknown>, void* context);

override

> Source/JavaScriptCore/runtime/JSString.h:413
> +    inline JSString* jsStringWithWeakOwner(VM* vm, const String& s)

's' is kind of an unWebKitty variable name but I guess it's okay in this context.

> Source/JavaScriptCore/runtime/JSString.h:418
> +        // If this vm is not allowed weakly own strings just call jsString.

allowed *to*

> Source/JavaScriptCore/runtime/JSString.h:427
> +            impl->setWeakJSString(0);

0 -> nullptr

> Source/JavaScriptCore/runtime/VM.cpp:173
> +    , jsStringWeakOwner(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:169
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:187
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:205
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:219
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:233
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:247
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:260
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:274
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:288
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:306
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WTF/wtf/text/StringImpl.h:326
> +        , m_weakJSString(0)

0 -> nullptr

> Source/WebCore/bindings/js/DOMWrapperWorld.h:-36
> -typedef JSC::WeakGCMap<StringImpl*, JSC::JSString, PtrHash<StringImpl*>> JSStringCache;

I guess we don't need the WeakGCMap.h include after this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.