[Webkit-unassigned] [Bug 128115] [Win] LLINT is not working.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 17 10:04:30 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128115





--- Comment #55 from Michael Saboff <msaboff at apple.com>  2014-02-17 10:01:42 PST ---
(In reply to comment #54)
> (In reply to comment #52)
> > (From update of attachment 224237 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=224237&action=review
> > 
> > > Source/JavaScriptCore/ChangeLog:29
> > > +        * llint/LowLevelInterpreter.asm: Remove instruction which generates incorrect assembly code on Windows (MOV 0xbbadbeef, register), call llint_crash instead.
> > 
> > This seems like really shady engineering.  Why can't you generate that instruction on Windows?  It's just an x86 instruction, and I'm sure that MASM has an encoding for it.
> 
> My mistake,
> 
> I should have investigated further why this doesn't seem to work with MASM.
> 
> The instruction "storei t0, 0xbbadbeef[]" translates to "mov 3148725999, eax" on Windows.
> This fails to compile with the message "error A2001:immediate operand not allowed".
> The same goes for the instruction "mov [3148725999], eax"

A little looking on the web says that masm may have an issue with "mov [123], <reg>".
What about "mov dword ptr [3148725999], eax"?  If that doesn't work, put 0xbbadbeef in one register and use it as the destination address.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list