[Webkit-unassigned] [Bug 128549] ENABLED(JIT) && !ENABLED(DFG_JIT) breaks the build
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 17 04:43:21 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=128549
Csaba Osztrogonác <ossy at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #224057|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #12 from Csaba Osztrogonác <ossy at webkit.org> 2014-02-17 04:40:32 PST ---
(From update of attachment 224057)
View in context: https://bugs.webkit.org/attachment.cgi?id=224057&action=review
r-, because it can't be applied now.
> Source/JavaScriptCore/jit/Repatch.cpp:825
> +#if ENABLE(DFG_JIT)
> MacroAssembler::Jump definitelyNotMarked = DFG::SpeculativeJIT::genericWriteBarrier(jit, owner, scratch1, scratch2);
> - MacroAssembler::Call call = storeToWriteBarrierBuffer(jit, owner, scratch1, scratch2, allocator);
> definitelyNotMarked.link(&jit);
> +#endif // ENABLE(DFG_JIT)
> +
> + MacroAssembler::Call call = storeToWriteBarrierBuffer(jit, owner, scratch1, scratch2, allocator);
Are you sure if this is the proper fix? I don't understand this code, but these lines looks to me as they can't be separated.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list