[Webkit-unassigned] [Bug 128727] CC and PKG_CONFIG should be quoted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128727





--- Comment #8 from Alberto Garcia <berto at igalia.com>  2014-02-16 14:40:01 PST ---
(In reply to comment #7)
> > In what case does an unquoted PKG_CONFIG break?
> It may not break. I found it when I found the unquoted CC, so I
> patched both CC and PKG_CONFIG.

Well, the Makefile is full of unquoted variables (e.g. PYTHON in that
very same line) :)

Quoting PKG_CONFIG doesn't harm, but it probably doesn't fix anything
either. I'd bet that if there was a case where PKG_CONFIG needed to be
quoted something else would break.

Anyway, quoting CC is fine. Altough, as Žan says, compiler flags
shouldn't generally go there, setting CC to "icecc gcc", "ccache gcc"
and friends is common practice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.