[Webkit-unassigned] [Bug 128115] [Win] LLINT is not working.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128115





--- Comment #53 from Mark Lam <mark.lam at apple.com>  2014-02-15 11:39:24 PST ---
(In reply to comment #52)
> (From update of attachment 224237 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224237&action=review
> 
> > Source/JavaScriptCore/ChangeLog:29
> > +        * llint/LowLevelInterpreter.asm: Remove instruction which generates incorrect assembly code on Windows (MOV 0xbbadbeef, register), call llint_crash instead.
> 
> This seems like really shady engineering.  Why can't you generate that instruction on Windows?  It's just an x86 instruction, and I'm sure that MASM has an encoding for it.

I thought of that when I reviewed it, but then thought that calling a helper function had an advantage.  Specifically, this way, we can crash in the platform defined way as specified by the CRASH() macro, and we don’t have a separate interpretation of what we should do to crash in the LLINT.  With that, I didn’t bother pushing for the implementation of the equivalent asm instruction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.