[Webkit-unassigned] [Bug 128867] Setting currentTime on HTMLMediaElement with media controller should throw exception

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128867


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224297|review?, commit-queue?      |review+
               Flag|                            |




--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2014-02-15 08:24:53 PST ---
(From update of attachment 224297)
View in context: https://bugs.webkit.org/attachment.cgi?id=224297&action=review

> LayoutTests/media/video-controller-currentTime.html:7
> +            function start() {

Nit: a function's opening brace should be on a new line.

> LayoutTests/media/video-controller-currentTime.html:13
> +            function canPlayThrough() {

Ditto.

> LayoutTests/media/video-controller-currentTime.html:19
> +                try {
> +                    video.currentTime = 3;
> +                } catch (e) {
> +                    consoleWrite(e);
> +                    endTest();
> +                }

You should also test that an INVALID_STATE_ERR exception is thrown, eg.:

testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.