[Webkit-unassigned] [Bug 128731] There is no rate change event when user agent modifies playback rate.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128731





--- Comment #4 from Piotr Grad <p.grad at samsung.com>  2014-02-14 02:52:51 PST ---
(In reply to comment #2)
> (From update of attachment 224056 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224056&action=review
> 
> > Source/WebCore/platform/graphics/MediaPlayer.cpp:1097
> > +    if (!std::isnan(m_private->rate()))
> 
> This...
> 
> > Source/WebCore/platform/graphics/MediaPlayerPrivate.h:90
> > +    virtual float rate() const { return std::numeric_limits<float>::infinity(); }
> 
> Does not match this. So for every platform which does not yet implement this method, rateChanged() notifications will result in the "rate" being set to infinity.
> 
> Additionally, this means that in the event of a buffer underrun, the video element will fire a ratechanged event in addition to a stalled event.  I do not believe this is correct.
> 
> Perhaps you could add more information about what problem you are attempting to solve, and we could come up with a better solution?

You have right about NaN, sorry for mistake.
The problem is when media player cannot handle playback rate which was set by HTMLMediaElement. In this case UA should update playbackRate in HTMLMediaElement and fire ratechange event.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.