[Webkit-unassigned] [Bug 128723] [css3-text] Support -webkit-text-decoration-skip: objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128723





--- Comment #10 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2014-02-13 23:41:40 PST ---
Hi Myles,

I know you are not reviewer. If this patch seems good, I'll ask some reviewers to review or rubber stamp this. 

(In reply to comment #6)
> (From update of attachment 224045 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224045&action=review
> 
> I know this is probably too late since the patch has already been submitted, but you should also have a test that does something like <u><img src="....."></u> compared to just the image alone to make sure it doesn't get underlined. That test should also test all the "atomic inline" objects that the spec describes

Added test case. I created the test to normal CSS test because this is default behavior even if text-decoration-skip: auto is implemented.

> > Source/WebCore/rendering/InlineTextBox.cpp:1173
> > +                    // FIXME: Need to support text-decoration-skip: none.
> 
> This is the wrong place for such a comment. InlineTextBoxes always get underlined; it's the other InlineBoxes that don't.

Moved.

> > Source/WebCore/rendering/style/RenderStyle.h:1674
> > +    static TextDecorationSkip initialTextDecorationSkip() { return TextDecorationSkipObjects; }
> 
> Should probably test this as well.

I think "stylesheet.insertRule(".p { }", 0);" test case in text-decoration-skip-roundtrip.html covers this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.