[Webkit-unassigned] [Bug 128723] [css3-text] Support -webkit-text-decoration-skip: objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128723





--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com>  2014-02-13 15:38:58 PST ---
(From update of attachment 224045)
View in context: https://bugs.webkit.org/attachment.cgi?id=224045&action=review

I know this is probably too late since the patch has already been submitted, but you should also have a test that does something like <u><img src="....."></u> compared to just the image alone to make sure it doesn't get underlined. That test should also test all the "atomic inline" objects that the spec describes

> Source/WebCore/rendering/InlineTextBox.cpp:1173
> +                    // FIXME: Need to support text-decoration-skip: none.

This is the wrong place for such a comment. InlineTextBoxes always get underlined; it's the other InlineBoxes that don't.

> Source/WebCore/rendering/style/RenderStyle.h:1674
> +    static TextDecorationSkip initialTextDecorationSkip() { return TextDecorationSkipObjects; }

Should probably test this as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.