[Webkit-unassigned] [Bug 123716] SVG rectangle with filter will not render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123716


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224089|review?                     |review-
               Flag|                            |




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-02-13 14:00:31 PST ---
(From update of attachment 224089)
View in context: https://bugs.webkit.org/attachment.cgi?id=224089&action=review

> Source/WebCore/ChangeLog:8
> +        A filtered SVG element with width or length bigger than 5.000

You should write this as 5000 or 5,000. 5.000 sounds like decimal 5.

> Source/WebCore/ChangeLog:10
> +	(counting the margin/border) will fail to render. This patch will
> +	instead test against the total element area.

Weird indentation

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:42
> +static const float kMaxFilterLength = 8192;

Length is ambiguous here. Length of what? Dimension would be better.

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:84
> +

Extra blank line.

> Source/WebCore/platform/graphics/filters/FilterEffect.h:62
> +    static bool isFilterSizeValid(const IntRect&);
> +    static bool isFilterSizeValid(const FloatRect&);

Are both really necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.