[Webkit-unassigned] [Bug 128731] There is no rate change event when user agent modifies playback rate.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128731


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224056|review?                     |review-
               Flag|                            |




--- Comment #2 from Jer Noble <jer.noble at apple.com>  2014-02-13 08:30:05 PST ---
(From update of attachment 224056)
View in context: https://bugs.webkit.org/attachment.cgi?id=224056&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:1097
> +    if (!std::isnan(m_private->rate()))

This...

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:90
> +    virtual float rate() const { return std::numeric_limits<float>::infinity(); }

Does not match this. So for every platform which does not yet implement this method, rateChanged() notifications will result in the "rate" being set to infinity.

Additionally, this means that in the event of a buffer underrun, the video element will fire a ratechanged event in addition to a stalled event.  I do not believe this is correct.

Perhaps you could add more information about what problem you are attempting to solve, and we could come up with a better solution?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.