[Webkit-unassigned] [Bug 127800] WebKitGTK+ should stop using COMPILE_ASSERT_MATCHING_ENUM macros

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127800


Enrique Ocaña <eocanha at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eocanha at igalia.com




--- Comment #3 from Enrique Ocaña <eocanha at igalia.com>  2014-02-12 03:20:12 PST ---
Thanks for the review, Martin.

I'd like to have opinions from you and Carlos about the way I handled the maintenance of the targetList, because I'm not sure if I took the right approach or if it can be improved:

Before the patch, the inner PasteboardHelper::defaultPasteboardHelper()->targetList() was returned to the client app using WebKitGTK+. It worked because the values held by that GtkTargetList were of type PasteboardHelper::PasteboardTargetType, which was cast-compatible with WebKitWebViewTargetInfo (the type the client app expects). That inner GtkTargetList was owned and maintained by PasteBoardHelper. The client app just used it without worrying.

Now we have to maintain a converted GtkTargetList holding WebKitWebViewTargetInfo items and mirroring the original GtkTargetList in PasteBoardTargetType. I didn't examine the code deep enough to understand the implications of mirroring the inner list. In particular, I dont know if the original list:

- Is created once and never changes. I'm re-creating a new list at each API request. This means that if the client asks for it twice, it will have two different lists! (maybe with different values). If the list never changes, I can save some code and use a single centralized mirror list.

- Is read-only or, on the contrary, is expected to be modified by the client app. I only synchronized the lists in the PasteBoardHelper --> WebKitWebView direction, not the opposite. If the client adds values to the list, they will pass unnoticed. Moreover, due to the nature of GtkTargetList, I don't have any way of knowing if the client adds new elements and to trigger a synchronization in the the WebKitWebView --> PasteBoardHelper direction.

So, please, can I have your opinion about all this?

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.