[Webkit-unassigned] [Bug 128632] GIF animations should be suspended when outside of viewport

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 11 17:50:23 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128632


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223923|review?                     |review+
               Flag|                            |




--- Comment #4 from Andreas Kling <akling at apple.com>  2014-02-11 17:47:39 PST ---
(From update of attachment 223923)
View in context: https://bugs.webkit.org/attachment.cgi?id=223923&action=review

r=me

> Source/WebCore/page/Page.cpp:1149
> +        if (frame->contentRenderer())
> +            frame->contentRenderer()->resumePausedImageAnimationsIfNeeded();

I'd put the renderer in a local.

> Source/WebCore/rendering/RenderElement.cpp:1287
> +    if (document.view()->isOffscreen())
> +        return false;

renderer.frameView().isOffscreen()

> Source/WebCore/rendering/RenderElement.cpp:1290
> +    if (document.frame()->timersPaused())
> +        return false;

renderer.frame().timersPaused()

> Source/WebCore/rendering/RenderElement.cpp:1304
> +    auto visibleRect = document().view()->visibleContentRect();

frameView().visibleContentRect()

> Source/WebCore/rendering/RenderElement.h:206
> +    virtual void newImageAnimationFrameAvailable(CachedImage&) override;

This should be final, too!

> Source/WebCore/rendering/RenderView.cpp:1181
> +void RenderView::addRendererWithPausedImageAnimations( RenderElement& renderer)

Weird space here!

> Source/WebCore/rendering/RenderView.cpp:1203
> +    Vector<RenderElement*> toRemove;

I'd give this some token inline capacity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list