[Webkit-unassigned] [Bug 128626] Lowering of CheckArray in FTL not supported for all types.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128626


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223910|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2014-02-11 16:19:54 PST ---
(From update of attachment 223910)
View in context: https://bugs.webkit.org/attachment.cgi?id=223910&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4715
> -        case Array::Contiguous: {
> +        case Array::Contiguous: 
> +        case Array::ArrayStorage: 
> +        case Array::SlowPutArrayStorage: {
>              LValue indexingType = m_out.load8(
>                  m_out.loadPtr(cell, m_heaps.JSCell_structure),
>                  m_heaps.Structure_indexingType);

I don't think that you can just add ArrayStorage and SlowPutArrayStorage here.  See SpeculativeJIT::jumpSlowForUnwantedArrayMode().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.