[Webkit-unassigned] [Bug 128388] Make EWS retry one more time after cleaning the build directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 08:14:38 PST 2014


--- Comment #8 from Adrian Perez <aperez at igalia.com>  2014-02-10 08:11:54 PST ---
(In reply to comment #4)
> I understand your intention to fix this annoying problem,  
> but I'm not sure if it is the best fix for it. 
> In my opinion it is too intrusive to remove the whole WebKitBuild (
> including WebKitBuild/Dependencies too) always when the tree is red
> or an incremental build issue occur. I think a simple "tree redness"
> occur more often than the mentioned gtkdoc issue. And it seems it is
> a GTK only problem, why should we remove the WebKitBuild on every
> "tree redness" on every EWS?

Note that the “webkit-build-directory” script is used to obtain the
build directory, so “WebKitBuild/Debug” or “WebKitBuild/Release” can
be removed, but “WebKitBuild/Dependencies” is never removed. Also,
provided that I would expect EWS bots to have “ccache” installed,
so in reality applying the patch is not that intrusive.

> I would prefer fixing gtkdoc somehow. Until the proper fix I can accept
> a GTK only workaround like you proposed or a less intrusive workaround,
> for example removing only the WebKitBuild/.../DerivedSources directory,

Fixing the invocation of gtk-doc is something that should also be
done. Nevertheless, there can be other cases in which the EWS bots
could choke and need a clean build—wiping just the derived sources
may not be enough.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list