[Webkit-unassigned] [Bug 125064] Fix EFL build with INSPECTOR disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 02:14:10 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=125064





--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-02-10 02:11:22 PST ---
(From update of attachment 223329)
View in context: https://bugs.webkit.org/attachment.cgi?id=223329&action=review

>>> Source/WebCore/inspector/ScriptCallFrame.cpp:38
>>>  #include <inspector/InspectorValues.h>
>> 
>> Isn't it also more clear to contain this inclusion by ENABLE(INSPECTOR) ?
> 
> Are you sure if it is good? As far as I remember InspectorValues.h
> doesn't have ENABLE(INSPECTOR) guard intentionally, because it
> is used on many places regardless of enabled/disabled inspector.

Ah, right. InspectorValues.h is being used by many places regardless of enabled/disabled inspector. I only saw where it is used on ENABLE(INSPECTOR) guard. Sorry for noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list