[Webkit-unassigned] [Bug 98931] [GTK] Enable touch features

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98931





--- Comment #40 from Zan Dobersek <zandobersek at gmail.com>  2014-02-10 01:13:29 PST ---
(From update of attachment 223617)
View in context: https://bugs.webkit.org/attachment.cgi?id=223617&action=review

Landed a couple of fixes that were crashing the related tests in 
http://trac.webkit.org/changeset/163774

> Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:40
> +    case GDK_TOUCH_BEGIN: {
> +        ASSERT(m_touchEvents.contains(sequence));

This ASSERT now checks for the opposite, which is what was most likely intended.

> Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:475
> +    m_touchEvents.append(std::move(event));
> +    m_updatedTouchEvents.add(GPOINTER_TO_INT(event->touch.sequence));

std::move() moves the event object into the vector and invalidates the local variable, so dereferencing that variable caused crashes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.