[Webkit-unassigned] [Bug 128502] [Mac] offlineasm build phases have incorrect dependencies specified, waste 4+ seconds on every build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128502





--- Comment #1 from Filip Pizlo <fpizlo at apple.com>  2014-02-09 11:47:41 PST ---
(In reply to comment #0)
> The total time taken to run generate_offset_extractor.rb and asm.rb is 4+ seconds on my Mac Pro, and they run on every build irrespective of whether their inputs have changed. This accounts for more than 50% of the time spent in a no-op build. asm.rb is the most expensive of the two.
> 
> The dependencies on the script phase that runs generate_offset_extractor.rb in the LLInt Offsets target has incorrect dependencies specified, leading it to be invoked on every build. The script phase that runs asm.rb has no dependencies specified, leading it to also be invoked on every build.

Agreed.  I did this because I wanted to err on the side of correctness.  generate_offsets_extractor only depends on the Ruby code in offlineasm and the .asm code in llint.  asm.rb only depends on the ruby code in offlineasm, the .asm code in llint, and the LLInt offsets binary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.