[Webkit-unassigned] [Bug 128389] [GTK] Make process model names properly meaningful
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 7 13:42:32 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=128389
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #223492|review? |review+
Flag| |
--- Comment #3 from Martin Robinson <mrobinson at webkit.org> 2014-02-07 13:39:51 PST ---
(From update of attachment 223492)
View in context: https://bugs.webkit.org/attachment.cgi?id=223492&action=review
Looks good to me. Needs one more GTK+ reviewer to be committed.
> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> + if (newProcessModel != context->priv->context->processModel()) {
> + context->priv->context->setUsesNetworkProcess(newProcessModel == ProcessModelMultipleSecondaryProcesses);
> + context->priv->context->setProcessModel(newProcessModel);
Nit: This should probably be an early return.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list