[Webkit-unassigned] [Bug 125399] Make indent command to work with positional CSS selector, e.g. :first-child, with visibility

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 7 02:32:11 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=125399





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2014-02-07 02:29:29 PST ---
(From update of attachment 218842)
View in context: https://bugs.webkit.org/attachment.cgi?id=218842&action=review

> Source/WebCore/ChangeLog:3
> +        Make indent command to work with positional CSS selector, e.g. :first-child, with visibility.

The bug title should be modified to reflect the fact this is a crash fix.

> Source/WebCore/editing/IndentOutdentCommand.cpp:82
> +    // We should calculate visible range in list item because inserting new
> +    // list element will change visibility of list item, e.g. :first-child
> +    // CSS selector.
> +    VisiblePosition startOfMove(start);
> +    VisiblePosition endOfMove(end);
> +

This comment doesn't explain why this is the right thing to do.
It appears to me that we should be failing out before calling moveParagraphWithClones
in the case where start & end up moving to unexpected places.

> LayoutTests/editing/execCommand/indent-with-first-child-crash.html:1
> +<style>

We can't have DOCTYPE here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list