[Webkit-unassigned] [Bug 128271] Grid layout properties are web-exposed even when grid layout is runtime-disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128271





--- Comment #3 from Sergio Villar Senin <svillar at igalia.com>  2014-02-06 02:18:05 PST ---
(In reply to comment #0)
> http://www.mobilexweb.com/blog/safari-ios7-html5-problems-apis-review:
> 
> CSS grid properties are exposed to JS through CSSStyleDeclaration even when grid layout is disabled (as it is in shipping Safari).

Correct me if I'm wrong but this is not a problem of grid layout per se. As far as I know in WebKit we do not hide properties that are runtime disabled. What we normally do is to enable/disable their parsing as it's done for example for CSS shapes, CSS regions etc.

This is easy to check, if you just disable one of those features and run  Object.getOwnPropertyDescriptor(document.body.style, property) you'll see how all those properties are exposed even though they're disabled at runtime.

So if we consider this an issue, I guess we do, we should remove grid layout from the title and start thinking about how to fix it. Maybe we should just filter the static list of properties removing the ones that are runtime disabled. As a reference Eric fixed this in Blink last year, see https://codereview.chromium.org/14324009.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.