[Webkit-unassigned] [Bug 117458] XMLHttpRequest performs too many copies for ArrayBuffer results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117458





--- Comment #12 from Filip Pizlo <fpizlo at apple.com>  2014-02-04 07:01:47 PST ---
(From update of attachment 223087)
View in context: https://bugs.webkit.org/attachment.cgi?id=223087&action=review

LGTM.  Did you mean to mark this as r?

> Source/JavaScriptCore/runtime/ArrayBuffer.h:99
> -    // Only for use by Uint8ClampedArray::createUninitialized.
> +    // Only for use by Uint8ClampedArray::createUninitialized and SharedBuffer::createArrayBuffer.

I agree with this change.  The reason why createUninitialized() is public is because it was impractical to use friends because of the template madness going on in Uint8ClamperArray.  This comment is a kind of unenforced "friend" replacement.

> Source/WebCore/platform/SharedBuffer.cpp:289
> +        ASSERT_NOT_REACHED();

I prefer RELEASE_ASSERT_NOT_REACHED().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.