[Webkit-unassigned] [Bug 127169] If not running on Mac, build-webkit should not print Safari related output

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127169





--- Comment #7 from Darin Adler <darin at apple.com>  2014-02-03 09:55:56 PST ---
(From update of attachment 222980)
View in context: https://bugs.webkit.org/attachment.cgi?id=222980&action=review

> Tools/Scripts/build-webkit:434
> +    if ($launcherPath && $launcherName) {
> +        print " To run $launcherName with this newly-built code, use the\n";
> +        print " \"$launcherPath\" script.\n";
> +    }

I understand this change.

> Tools/Scripts/webkitdirs.pm:1290
> -    } elsif (isAppleWebKit()) {
> +    } elsif (isDarwin()) {

Why this change? Unclear how this relates to what the change log says. This makes it look like it will use run-safari more often, for anyone running on a Darwin system. That seems like the opposite of what the change log says this patch does.

> Tools/Scripts/webkitdirs.pm:1307
> +    } elsif (isDarwin()) {
> +        return "Safari";
>      }

Same comment here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.