[Webkit-unassigned] [Bug 117458] XMLHttpRequest performs too many copies for ArrayBuffer results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117458





--- Comment #4 from Sergio Villar Senin <svillar at igalia.com>  2014-02-03 03:49:56 PST ---
(From update of attachment 222975)
View in context: https://bugs.webkit.org/attachment.cgi?id=222975&action=review

A couple of nits

> Source/JavaScriptCore/ChangeLog:7
> +

Although it's nice to refer to the source of the change, the ChangeLog should include a description of the patch at least including the savings we get.

> Source/WebCore/platform/SharedBuffer.cpp:295
> +    return arrayBuffer;

I think it's a good idea to use arrayBuffer.release() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.