[Webkit-unassigned] [Bug 25571] DOM range methods setStartBefore/setEndAfter fails on detached elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 3 01:16:17 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=25571





--- Comment #16 from Bhanu <b.rout at samsung.com>  2014-02-03 01:13:38 PST ---
The above patch fixes the range methods on detached node. I kept all the constraints as per DOM2 spec with additional null parent check as mentioned in the spec http://dom.spec.whatwg.org/ . The actual fix is made by allowing element node to be a root container though its not specified anywhere in the specs.

After looking at chromium code, I couldn't conclude whether to completely stick by DOM4 spec or both DOM2 as well as DOM4. So, I made the fix in similar fashion as chromium.

Chromium patch reference :
https://codereview.chromium.org/23404003

Chromium code reference :
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/dom/Range.cpp&q=range.cpp&sq=package:chromium

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list